fix(input): allow escape as a prefix-mode keybinding - #2322
Open
fraidev wants to merge 4 commits into
Open
Conversation
Prefix mode always canceled on Esc before binding lookup, so configs like copy_mode = "prefix+esc" (tmux bind Escape copy-mode) never ran. Unbound Esc still cancels prefix mode via the unmatched-key path.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughEscape now supports configured prefix-mode bindings through ChangesEscape prefix bindings
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant PrefixMode
participant KeybindingResolver
participant CopyMode
User->>PrefixMode: Press prefix then Escape
PrefixMode->>KeybindingResolver: Resolve configured Escape binding
KeybindingResolver->>CopyMode: Execute copy-mode action
PrefixMode-->>User: Exit prefix mode when Escape is unbound
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kangal-bot
added
the
ai-review
Greptile SummaryThis PR allows Escape to participate in normal prefix-mode keybinding dispatch while preserving cancellation for unbound Escape.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/app/input/navigate.rs | Reorders prefix-mode Escape handling so configured actions run before the existing fallback that leaves prefix mode, with tests for bound and unbound behavior. |
| src/config/keybinds.rs | Adds configuration tests confirming that case variants of both esc and escape resolve to an Escape prefix trigger. |
| docs/next/website/src/content/docs/configuration.mdx | Documents Escape aliases and the distinction between bound prefix actions and unbound cancellation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Escape pressed in prefix mode] --> B{Prefix binding matches Escape?}
B -->|Yes| C[Execute configured action]
B -->|No| D[Leave prefix mode]
Reviews (3): Last reviewed commit: "Merge branch 'master' into fix/prefix-es..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Esc always canceled prefix mode before keybinds ran, so copy_mode = "prefix+esc" (like tmux bind Escape copy-mode) never worked even though the config accepted it.
This treats Esc as a normal prefix RHS when bound; unbound Esc still cancels prefix mode.
Happy to adjust anything if needed.